Conversation
Contributor
|
Wow that name takes the Pixhawk, PX4, Pi naming confusion to a new level 😄 |
Member
|
This is harmless to bring in if you'd like to continue working on it incrementally in main. |
dakejahl
reviewed
Mar 15, 2024
92c618c to
1717b80
Compare
5c97908 to
e0d04a6
Compare
dagar
previously approved these changes
Apr 10, 2024
dagar
previously approved these changes
Apr 10, 2024
dagar
approved these changes
Apr 12, 2024
MaEtUgR
added a commit
that referenced
this pull request
May 29, 2024
…'s no memory allocated with APP_RESERVATION_SIZE I adepted to the nxt-v1 board which seems similar and has flash based params disabled. The reason I'm doing this change is becuase CI is failing with a combination of the hkust board support: #22961 f7bc13d and an additional check for the exact issue introduced with: #22829 528ad1e
MaEtUgR
reviewed
May 29, 2024
Comment on lines
+75
to
+76
| * If APP_RESERVATION_SIZE is greater than 0 and | ||
| * FLASH_BASED_PARAMS is defined, throw a compile error |
Member
There was a problem hiding this comment.
The comment says the opposite of what it does below instead of explaining why. Could you please clarify? 😇
Member
Author
There was a problem hiding this comment.
Probably should say is not greater.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress for the new ARK Pi6X flight controller.
https://arkelectron.com/product/ark-pi6x-flow
Airframe kits will be available through Droneblocks. I have added a placeholder airframe file for the kit.