Conversation
ec6f0b5 to
490cd52
Compare
8e4a9fb to
943b8e9
Compare
4ae0101 to
ac307bd
Compare
ThomasDebrunner
previously approved these changes
Nov 13, 2023
Contributor
|
@KonradRudin Looks like this is getting close. Let me know when it is ready to merge and you have test results/stuff we can use to validate this (so that I can push for merging of the MAVLink changes). |
dagar
previously approved these changes
Nov 20, 2023
Member
|
As soon as mavlink/mavlink#2012 is merged we can update the mavlink submodule and bring this in. |
216dc7a
486aa7e to
216dc7a
Compare
Contributor
Author
|
rebased on main again |
Contributor
Author
|
@hamishwillee This PR was discussed now in the maintainer call and in agreement wirh @dagar . This side is ready now |
216dc7a to
34e7d85
Compare
Contributor
Author
|
Upstream mavlink is merged now. Update the mavlink submodule |
34e7d85 to
096098b
Compare
dagar
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
This PR adds support for the Mavlink Mission opaque ID as defined in mavlink/mavlink#2012. It is based on the earlier implementation for the mission checksum support in #18418, but the mission checksum in Mavlink will be deprecated in mavlink/mavlink#2010.
Solution
Changelog Entry
For release notes:
Alternatives
Opqaue id could also just be a counter instead of the Crc32. The hash implementation has the advantage that on loading the same mission (e.g. also from a file) should result in the same Id and thus the potentially multiple connected GCS does not need to download it again. Also it would allow for the feature, that a GCS does not need to download the mission on first connection if the old stored mission and opaque id is the same.
Test coverage
Context