development.xml - remove mission_checksum#2010
Merged
hamishwillee merged 1 commit intomasterfrom Aug 9, 2023
Merged
Conversation
This was referenced Jul 12, 2023
Contributor
Author
|
FYI @auturgy I am merging this. It doesn't work and we don't want anyone else to try implement it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes MISSION_CHECKSUM .
MISSION_CHECKSUM is supposed to provide a checksum of various parts of the plan. The theory is that a ground station can calculate the same checksum for its current plan and therefore know if it has the current fence, mission, rally points.
Unfortunately the theory is flawed because flight stacks do not necessarily store all the data in the original mission.
Replaced the functionality by #2012