feat(prql-compiler): make prql_compiler::PRQL_VERSION public
#1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sure. |
Member
Author
|
Thank you for quick response and merging this! |
Member
|
@eitsupi I added you with write permissions on the repo, so feel free to merge these sorts of things yourself (easy to revert if anything goes wrong!). |
Member
Author
|
@max-sixty Thank you very much. I am honored. |
aljazerzen
pushed a commit
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding prql-compiler in a package such as prqlr (own version does not match prql-compiler version), it would be useful to be able to easily check the version of the embedded prql-compiler. (PRQL/prqlc-r#51)
If the release cycle is fast (related to #1507), downstream software may not be able to keep up with the latest version, so users will want to check the version of PRQL that is supported.