Skip to content

Conversation

@Warrows
Copy link

@Warrows Warrows commented Jul 7, 2019

Backport of bitcoin#14504, bitcoin#14569 and bitcoin#15466.
This should help to see which test takes too long or blocks travis when it hangs because of the 50 minutes limit.

isghe and others added 3 commits July 7, 2019 09:04
example (added the progress index `n/m`)
```
1/107 - wallet_hd.py passed, Duration: 27 s
.........................................................................................
2/107 - mining_getblocktemplate_longpoll.py passed, Duration: 72 s
..................................................................
3/107 - feature_maxuploadtarget.py passed, Duration: 78 s
```

- clear dots line
```
$ test/functional/test_runner.py -t can_trash
Temporary test directory at can_trash/test_runner_₿_🏃_20181018_220600
1/105 - wallet_hd.py passed, Duration: 21 s
2/105 - mining_getblocktemplate_longpoll.py passed, Duration: 71 s
3/105 - feature_maxuploadtarget.py passed, Duration: 68 s
..................
```

- don't print the `dot` progressive if `--quiet`

- done_str
- nothing commit to check again travis tests
This helps finding out which tests fail to finish.
@Fuzzbawls
Copy link
Collaborator

utACK ae0b4d0

@Warrows Warrows changed the title [Travis] Show functional tests progress [WIP] [Travis] Show functional tests progress Jul 9, 2019
@Warrows
Copy link
Author

Warrows commented Jul 9, 2019

Added backport of bitcoin#16214

Travis was regularly failing because the full test suite with coverage
takestoo much time.
Bitcoin has some optimisations in there which allows them to give less
time to the test part of the process. We don't so until we do, we have
to reserve more time. We will probably have to restart manually more
travis jobs but that's the only way to have them run to the end.
@Warrows Warrows changed the title [WIP] [Travis] Show functional tests progress [Travis] Show functional tests progress Jul 9, 2019
@Warrows
Copy link
Author

Warrows commented Jul 9, 2019

This is good to go now. This should avoid seeing travis build fail at the 50mn mark with no way to get them to succeed.

@Fuzzbawls
Copy link
Collaborator

ACK 5fbf26c

@Fuzzbawls Fuzzbawls merged commit 5fbf26c into PIVX-Project:master Jul 11, 2019
Fuzzbawls added a commit that referenced this pull request Jul 11, 2019
5fbf26c [Travis] Give more time to tests (warrows)
1aa76d0 travis: Use absolute paths for cache dirs (MarcoFalke)
1fa0bf3 travis: Fix caching issues (MarcoFalke)
e4945a2 [Travis] Log more info (warrows)
ae0b4d0 tests: Print remaining jobs in test_runner.py (Steven Roose)
a57939f tests: Print dots by default (Chun Kuan Lee)
cde9d13 show the progress of functional test (Isidoro Ghezzi)

Pull request description:

  Backport of bitcoin#14504, bitcoin#14569 and bitcoin#15466.
  This should help to see which test takes too long or blocks travis when it hangs because of the 50 minutes limit.

ACKs for commit 5fbf26:
  Fuzzbawls:
    ACK 5fbf26c

Tree-SHA512: 0c2bebd8f160e2c6358a598f3cf95c3451068af1b5e269d79366fe890f9609c140555cb182f0f4563dac35a0a433556eaf06e4a45865fd55bdd357130acc1d2c
@Warrows Warrows deleted the 2019_travis_log-current-functional-test branch July 11, 2019 07:56
@Fuzzbawls Fuzzbawls added the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Jul 28, 2019
@random-zebra random-zebra added this to the 4.0.0 milestone Aug 6, 2019
@random-zebra random-zebra modified the milestones: 4.0.0, 3.4.0 Aug 25, 2019
@Fuzzbawls Fuzzbawls removed the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants