[RPC] Fix RPCTimerInterface #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9572856 to
0053876
Compare
Mrs-X
approved these changes
Oct 7, 2018
Mrs-X
left a comment
There was a problem hiding this comment.
Compared to upstream: utACK
Tested: ACK
Mrs-X
added a commit
that referenced
this pull request
Oct 14, 2018
0053876 [RPC]: Fix RPCTimerInterface ordering issue (bitcoin#7317) (random-zebra) Tree-SHA512: 0e3b5ea32d48d824e37fff701c420e835c1da011cfe10302d47773341ca303ad680b85b2e6d505cda6d29be3e1c0964ee5880f66a67b1aed07aa510ba6fdc312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running the wallet with
-serverand usingwalletpassphraseover the RPC server (not the GUI console), the wallet doesn't lock again when the timeout expires, it stays unlocked indefinitely.This is fixed in upstream Bitcoin and might allow to finally address this #553 too.