forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 725
[BUG][Masternodes] Prevent broadcast of pre-5.0 stale masternode data #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
furszy
merged 3 commits into
PIVX-Project:master
from
random-zebra:202101_tiertwo-stale_cachedata
Jan 14, 2021
Merged
[BUG][Masternodes] Prevent broadcast of pre-5.0 stale masternode data #2136
furszy
merged 3 commits into
PIVX-Project:master
from
random-zebra:202101_tiertwo-stale_cachedata
Jan 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d213f7 to
e4c6311
Compare
e4c6311 to
6838ddf
Compare
furszy
reviewed
Jan 13, 2021
furszy
reviewed
Jan 13, 2021
Fuzzbawls
approved these changes
Jan 13, 2021
Collaborator
Fuzzbawls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 6838ddf
furszy
approved these changes
Jan 14, 2021
furszy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6838ddf and merging
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jan 14, 2021
Github-Pull: PIVX-Project#2136 Rebased-From: 71fe589
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jan 14, 2021
Github-Pull: PIVX-Project#2136 Rebased-From: 0cf23fa
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Jan 14, 2021
Github-Pull: PIVX-Project#2136 Rebased-From: 6838ddf
furszy
added a commit
that referenced
this pull request
Jan 14, 2021
40a66b6 [Net] Add new mainnet checkpoint for main net block 2678402 (random-zebra) e3ce162 [Consensus] Bump active protocol to 70921 (random-zebra) 5b9592b Tests: Add block value test to budget_tests.cpp (random-zebra) 6f0e0a8 Consensus: Fix IsBlockValueValid for superblocks (random-zebra) 570f038 [Masternodes] Don't ban invalid pings before enforcement (random-zebra) 3e86266 [DB] Don't check file contents when dumping budgets/mnodes/payments (random-zebra) 30f41fe [DB] Add database version to the cache files for tiertwo managers (random-zebra) b9800ef Check interruptNet during dnsseed lookups (Matt Corallo) a0184d2 [Cleanup] Remove unused CInv string-ctr, make GetCommand private (random-zebra) 66018c7 [P2P] Proper order of ppszTypeName and allNetMessageTypes (random-zebra) 0a235b6 Do not make it trivial for inbound peers to generate log entries (Matt Corallo) 910f83f [Net] Remove unused RecvLine function. (furszy) ed1d377 [GUI] Receive screen, fix missing "Add label" text. (furszy) Pull request description: backport the following PRs to the `5.0` branch: #2128 #2133 #2130 #2134 #2129 #2136 #2137 ACKs for top commit: furszy: ACK 40a66b6 random-zebra: ACK 40a66b6 Tree-SHA512: b7c149645c935838bdcfb82c66e8522815f48e8c4e9354af889fba8d6e9c50fad178e2de6b28ac72174e0d513d9ff484a517b6fa036d3478e410e447df73d847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is currently causing excessive banning.
Add a "database" version at the beginning of cache files.
Also, for this reason, do not ban when receiving invalid ping block hashes before the enforcement of protocol 70921.