ReservedFunctionNames: ignore deprecated functions#917
Merged
Conversation
Check the function docblock for a `@deprecated` tag and if found, bow out. Includes unit tests. Fixes 911
wimg
approved these changes
Oct 16, 2019
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 13, 2026
…nd `__ngettext_noop()`. Since PHPCompatibility 9.3.2, the `ReservedFunctionNames` sniff skips functions with a `@deprecated` tag. Reference: [PHPCompatibility/PHPCompatibility#917 WPCS: ReservedFunctionNames: ignore deprecated functions]. Follow-up to [46290]. Props rodrigosprimo. See #64627. git-svn-id: https://develop.svn.wordpress.org/trunk@61641 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 18, 2026
…nd `__ngettext_noop()`. Since PHPCompatibility 9.3.2, the `ReservedFunctionNames` sniff skips functions with a `@deprecated` tag. Reference: [PHPCompatibility/PHPCompatibility#917 WPCS: ReservedFunctionNames: ignore deprecated functions]. Follow-up to [46290]. Props rodrigosprimo. See #64627. Built from https://develop.svn.wordpress.org/trunk@61641 git-svn-id: http://core.svn.wordpress.org/trunk@60952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jihaisse
pushed a commit
to jihaisse/wordpress-develop
that referenced
this pull request
Feb 18, 2026
…nd `__ngettext_noop()`. Since PHPCompatibility 9.3.2, the `ReservedFunctionNames` sniff skips functions with a `@deprecated` tag. Reference: [PHPCompatibility/PHPCompatibility#917 WPCS: ReservedFunctionNames: ignore deprecated functions]. Follow-up to [46290]. Props rodrigosprimo. See #64627. git-svn-id: https://develop.svn.wordpress.org/trunk@61641 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the function docblock for a
@deprecatedtag and if found, bow out.Includes unit tests.
Fixes #911