PHP 8.3 | NewFunctions: recognize ldap_connect_wallet() and ldap_exop_sync() (RFC) #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> - LDAP: > . Added ldap_connect_wallet(). Note: the same (accepted) RFC which introduced this new function, also deprecates the signature of the `ldap_connect()` function with 3+ parameters, but that deprecation won't take effect until PHP 8.4. I do have an adjustment to the (new) `PHPCompatibility.ParameterValues.RemovedLdapConnectSignatures` sniff ready to handle this, but won't pull that update until the deprecation has been merged into PHP itself. Refs: * https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#ldap_connect * https://github.com/php/php-src/blob/548fc6a8185625bf50c708a9337db01f14860ba1/UPGRADING#L343-L344 * php/php-src 11703 * php/php-src@72aada3 * https://www.php.net/ldap_connect Related to 1589
> - LDAP: > . Added ldap_exop_sync(). Note: the same (accepted) RFC which introduced this new function, also deprecates the signature of the `ldap_exop()` function with 5/6 parameters, but that deprecation won't take effect until PHP 8.4. Refs: * https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#ldap_exop * https://github.com/php/php-src/blob/548fc6a8185625bf50c708a9337db01f14860ba1/UPGRADING#L345 * php/php-src 11703 * php/php-src@b3bd55f * https://www.php.net/ldap_exop Related to 1589
35 tasks
wimg
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.3 | NewFunctions: recognize ldap_connect_wallet() (RFC)
Note: the same (accepted) RFC which introduced this new function, also deprecates the signature of the
ldap_connect()function with 3+ parameters, but that deprecation won't take effect until PHP 8.4.I do have an adjustment to the (new)
PHPCompatibility.ParameterValues.RemovedLdapConnectSignatures(PR #1620) sniff ready to handle this, but won't pull that update until the deprecation has been merged into PHP itself.Refs:
PHP 8.3 | NewFunctions: recognize ldap_exop_sync() (RFC)
Note: the same (accepted) RFC which introduced this new function, also deprecates the signature of the
ldap_exop()function with 5/6 parameters, but that deprecation won't take effect until PHP 8.4.Refs:
Related to #1589