PHP 8.3 | ✨ New PHPCompatibility.ParameterValues.RemovedLdapConnectSignatures sniff (RFC)
#1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignatures` sniff (RFC) > - LDAP > . Calling ldap_connect() with separate hostname and port is deprecated. Refs: * https://wiki.php.net/rfc/deprecations_php_8_3#deprecate_calling_ldap_connect_with_2_parameters * https://github.com/php/php-src/blob/548fc6a8185625bf50c708a9337db01f14860ba1/UPGRADING#L146-L148 * php/php-src 5177 * php/php-src@69a8b63 This adds a new sniff to detect the above. **Note**: Normally this kind of change would be handled via the `RemovedFunctionParameters` sniff, but this function has *three* distinct signatures and the signatures are being deprecated in reverse order, i.e. the 2-param signature is being deprecated in PHP 8.3, while the 3+ param signature is being deprecated in PHP 8.4. For that reason, the `RemovedFunctionParameters` sniff is not suitable to handle this. Also note that, while the three+ param signature is still supported, passing a separate `$host` and `$port` is also deprecated for that signature. Instead a `$uri` should be passed and `$port` should be set to `null`. The sniff does take this into account and handles this via a separate error code. Includes tests and documentation. Related to 1589
35 tasks
wimg
approved these changes
Aug 10, 2023
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
This adds a new sniff to detect the above.
Note:
Normally this kind of change would be handled via the
RemovedFunctionParameterssniff, but this function has three distinct signatures and the signatures are being deprecated in reverse order, i.e. the 2-param signature is being deprecated in PHP 8.3, while the 3+ param signature is being deprecated in PHP 8.4. For that reason, theRemovedFunctionParameterssniff is not suitable to handle this.Also note that, while the three+ param signature is still supported, passing a separate
$hostand$portis also deprecated for that signature. Instead a$urishould be passed and$portshould be set tonull. The sniff does take this into account and handles this via a separate error code.Includes tests and documentation.
Related to #1589