Skip to content

Adds static function to call the Plugin::onDependenciesChangedEvent() method#5

Merged
frenck merged 7 commits intoPHPCSStandards:masterfrom
potherca-contrib:develop
Feb 14, 2017
Merged

Adds static function to call the Plugin::onDependenciesChangedEvent() method#5
frenck merged 7 commits intoPHPCSStandards:masterfrom
potherca-contrib:develop

Conversation

@Potherca
Copy link
Copy Markdown
Member

@Potherca Potherca commented Jan 11, 2017 •
edited
Loading

Fix for issue #4.

This PR expose a new method run. This can be use from a composer.json file like this:

{
    "name": "potherca/phpcodesniffer-composer-installer-example",
    "description": "Example to demonstrate the working of the dealerdirect/phpcodesniffer-composer-installer package.",
    "require": {
        "dealerdirect/phpcodesniffer-composer-installer": "*",
    },
    "scripts": {
        "run-phpcodesniffer-composer-installer": [
            "Dealerdirect\\Composer\\Plugin\\Installers\\PHPCodeSniffer\\Plugin::run"
        ]
    }
}

Beside this feature I have also done some minor code cleanup and added more message for in verbose mode.

@Potherca Potherca mentioned this pull request Jan 11, 2017
Closed
@Potherca Potherca requested a review from frenck February 3, 2017 08:29
@Potherca
Copy link
Copy Markdown
Member Author

Potherca commented Feb 3, 2017 •
edited
Loading

@frenck I would suggest merging #6 and #8 first, I'll pick up any merge-conflicts here afterwards and ping you for a review.

@frenck
Copy link
Copy Markdown
Contributor

frenck commented Feb 5, 2017

@Potherca Will do 👍

@frenck frenck assigned frenck and Potherca and unassigned frenck Feb 5, 2017
@frenck frenck mentioned this pull request Feb 7, 2017
Closed
@Potherca
Copy link
Copy Markdown
Member Author

Potherca commented Feb 9, 2017

@frenck Update complete, can be reviewed.

frenck
frenck suggested changes Feb 14, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, but missing some code documentation.

src/Plugin.php
$this->init();
}

private function init()
Copy link
Copy Markdown
Contributor

@frenck frenck Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation block.
Could you please add this?

src/Plugin.php
*/
private $processBuilder;

public static function run(Event $event)
Copy link
Copy Markdown
Contributor

@frenck frenck Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation block.
Could you please add this?

@Potherca
Copy link
Copy Markdown
Member Author

Potherca commented Feb 14, 2017

Docblocks fixed.

@frenck
Copy link
Copy Markdown
Contributor

frenck commented Feb 14, 2017

Thx!

@frenck frenck merged commit 305ff39 into PHPCSStandards:master Feb 14, 2017
@jrfnl jrfnl mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frenck frenck frenck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Potherca Potherca

Labels

Type: improvement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Potherca @frenck