Support existing standards packages with subfolders#6
Merged
frenck merged 4 commits intoPHPCSStandards:masterfrom Feb 5, 2017
Merged
Support existing standards packages with subfolders#6frenck merged 4 commits intoPHPCSStandards:masterfrom
frenck merged 4 commits intoPHPCSStandards:masterfrom
Conversation
Allows plugin installer to search for rulesets that are in a subfolder.
00a7e15 to
be10123
Compare
Contributor
Author
|
If this change or similar is accepted, allowing a slightly deeper directory tree for standards, I'll be submitting a change to the Drupal Coder module, asking them to adjust the package type from "library" to "phpcodesniffer-standard". See this fork |
Potherca
approved these changes
Feb 3, 2017
Member
|
Changes look good, motivation is solid. |
Contributor
Author
|
I've been using my changes with the following {
"type": "metapackage",
"minimum-stability": "dev",
"prefer-stable": true,
"config": {
"preferred-install": "dist",
"discard-changes": true
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/christopher-hopper/coder"
},
{
"type": "vcs",
"url": "https://github.com/christopher-hopper/phpcodesniffer-composer-installer"
}
],
"require": {
"php": ">=5.4",
"mouf/nodejs-installer": "~1.0"
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "dev-master",
"frenck/php-compatibility": "*",
"drupal/coder": "dev-8.x-2.x"
}
}Once merged I will be submitting a pull request to the |
frenck
approved these changes
Feb 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ruleset.xmlexists in a standards sub-folderMotivation
I want to use your excellent installer plugin with the Drupal PHP CodeSniffer standards. Their package uses a subfolder, one deeper than the repository root, which they're unable to change. I am sure there are other examples where Standards may be one or two folders deeper than the current installer allows.
Notify