Tests: add new InstallUpdateEventsTest and NonInstallUpdateEventsTest#174
Merged
Tests: add new InstallUpdateEventsTest and NonInstallUpdateEventsTest#174
Conversation
Test that the plugin is hooked into the right events and doesn't get triggered when those events are blocked (`--no-plugins`). These tests verify that: - The plugin gets triggered on install/update/require/remove/reinstall events. - The plugin doesn't run when Composer is run with `--no-plugins`. - The plugin does run when Composer is run with `--no-scripts` (since Composer 2.1.2). - Can be run on-demand via a custom script. This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions. The behaviour also shouldn't differ between a global vs local Composer install, so only testing one type. Note: the `composer reinstall` test will only run on Composer 2.2.6+ as prior to that release plugins would not run on that command. This test class covers the following bug previously reported: * Dealerdirect/phpcodesniffer-composer-installer issue 4 * Dealerdirect/phpcodesniffer-composer-installer PR 5
This new test class tests that the plugin doesn't get triggered on events it isn't hooked into.
Potherca
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Tests: add new InstallUpdateEventsTest
Test that the plugin is hooked into the right events and doesn't get triggered when those events are blocked (
--no-plugins).These tests verify that:
--no-plugins.--no-scripts(since Composer 2.1.2).This test is about Composer and the plugin, so does not need to be tested against multiple PHPCS versions.
The behaviour also shouldn't differ between a global vs local Composer install, so only testing one type.
Note: the
composer reinstalltest will only run on Composer 2.2.6+ as prior to that release plugins would not run on that command (discovered while working on these tests).This test class covers the following bug previously reported:
Tests: add new NonInstallUpdateEventsTest
This new test class tests that the plugin doesn't get triggered on events it isn't hooked into.
Related Issues
Related to #92