ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487#488
Merged
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom Aug 31, 2014
Merged
ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487#488keradus merged 1 commit intoPHP-CS-Fixer:masterfrom
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom
Conversation
Member
Author
|
Because all fixers deserve to use Tokens ;) |
7d4d326 to
c6bc9fa
Compare
This was referenced Aug 28, 2014
Closed
c6bc9fa to
79b2024
Compare
3 tasks
Contributor
|
@keradus when mentionning the fixed issues, it is better to put them in the PR description rather than the title. This way, they would get linked automatically |
Member
Author
|
Actually they were linked by commit ;) |
Contributor
|
Can you add a testcase for https://github.com/fabpot/PHP-CS-Fixer/issues/167 as well ? |
Member
Author
|
yes |
79b2024 to
ec8ab57
Compare
ec8ab57 to
fc78741
Compare
c3c1134 to
8897fce
Compare
Merged
Member
Author
|
any opinion ? |
Contributor
There was a problem hiding this comment.
shouldn't you use a backward iteration to avoid the need of bumping the limit ?
Member
Author
There was a problem hiding this comment.
Backward iteration help not bumping the limit when you add a Token at index greater than current iteration index.
Here we will add a Token at lesser index, one we do not meet yet, so we wiil need to increase limit as well. No gain.
Contributor
|
👍 |
Member
Author
|
merged |
keradus
added a commit
that referenced
this pull request
Aug 31, 2014
, #487 (keradus) This PR was merged into the 1.0.x-dev branch. Discussion ---------- ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487 ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487 Commits ------- 8897fce ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487
keradus
added a commit
that referenced
this pull request
Sep 9, 2014
This PR was squashed before being merged into the 1.0.x-dev branch (closes #472). Discussion ---------- BracesFixer Braces for structure blocks, fix #98 - [x] add missing braces - [x] correct single-level intend - [X] correct multi-level intend - [X] fix `T_FOR` token syntax - [X] ignore T_END* syntax - [X] make Travis pass - [X] fix #168 -> fixed in PR #488 - [X] fix #374 - [X] remove new line between `}` and T_ELSE, E_ELSEIF, T_CATCH - [X] detect duplicated functionality in CurlyBracketsNewlineFixer - [X] detect duplicated functionality in ControlSpacesFixer Commits ------- 5f3a1fd BracesFixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReturnStatements - rewrite to use Tokens and fix for #167, #341, #487