Conversation
tangge233
requested changes
Feb 3, 2026
Contributor
tangge233
left a comment
There was a problem hiding this comment.
写复杂了，只需要提供内容即可。就像社区资源那的版本选择一样，可以自己输入，也可以直接选择预设填入。
然后 ComboBox 是支持直接在 xaml 里写 Item 的，不要 CodeBehind
tangge233
previously requested changes
Feb 4, 2026
Contributor
tangge233
left a comment
There was a problem hiding this comment.
最后一点小问题，改完就能 merge 了 :)
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml.vb
Outdated
Show resolved
Hide resolved
ruattd
requested changes
Feb 4, 2026
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml
Outdated
Show resolved
Hide resolved
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml.vb
Outdated
Show resolved
Hide resolved
LinQingYuu
reviewed
Feb 5, 2026
ruattd
requested changes
Feb 5, 2026
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml.vb
Outdated
Show resolved
Hide resolved
ruattd
requested changes
Feb 5, 2026
Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml.vb
Outdated
Show resolved
Hide resolved
ruattd
approved these changes
Feb 5, 2026
MoYuan-CN
approved these changes
Feb 5, 2026
whitecat346
pushed a commit
that referenced
this pull request
Feb 7, 2026
* feat: 添加游戏窗口标题预设 * requested changes * change * change * change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2315