You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was a regression introduced in #192, which was rolled out in outline-server v1.10.0 released last week and caused issues for users using machines with IPv6 disabled: OutlineFoundation/outline-server#1601.
I'm unable to reproduce the issue itself when IPv6 is disabled on my corp or DigitalOcean machines, but that may be specific to those machines.
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But we need to verify whether it will fix the issue. Probably we can also have some configuration that let the user explicitly specify the IP stack (v4 or v6).
LGTM. But we need to verify whether it will fix the issue.
Agreed, though I'm still unable to reproduce this issue, on a host machine or in a Docker container. I had wanted to replicate this in the outline-server integration test, but to no avail. I propose merging this change and, as you suggested offline, creating a new canary release that we could ask affected folks to test.
Probably we can also have some configuration that let the user explicitly specify the IP stack (v4 or v6).
The new service config allows this now at the outline-ss-server layer; the new configuration allows a full address specification, instead of just a port:
But we don't yet support this at the outline-server/Manager layer. I agree it would be nice to explicitly specify the stack there, but I'm also not sure it's totally necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a regression introduced in #192, which was rolled out in outline-server v1.10.0 released last week and caused issues for users using machines with IPv6 disabled: OutlineFoundation/outline-server#1601.
I'm unable to reproduce the issue itself when IPv6 is disabled on my corp or DigitalOcean machines, but that may be specific to those machines.