refactor: allow hot swapping the config#192
Merged
Merged
Conversation
We introduce shared listeners that allow us to keep an old config running while we set up a new config. This is done by keeping track of the usage of the listeners and only closing them when the last user is done with the shared listener.
fortuna
requested changes
Jul 15, 2024
fortuna
left a comment
There was a problem hiding this comment.
I think we need to readjust some things. Happy to brainstorm more.
fortuna
requested changes
Jul 19, 2024
fortuna
reviewed
Jul 19, 2024
707bc35 to
80e5d49
Compare
Author
Added a read and close channel to the virtual packet connection. |
18e407a to
4730d74
Compare
fortuna
requested changes
Aug 8, 2024
fortuna
left a comment
There was a problem hiding this comment.
The new structure looks nicer. The main things now is the new virtual packet conn, which needs a redesign, and the RefCount can probably go away.
851ac28 to
8f9f1ea
Compare
sbruens
commented
Aug 9, 2024
sbruens
left a comment
Author
There was a problem hiding this comment.
This is ready for another look, @fortuna please take a look specifically at the packet conn handling. I ended up using a read and a response channel. I think this resolves the issue you pointed out, but I'm curious to hear what you think.
fortuna
reviewed
Aug 12, 2024
fortuna
left a comment
There was a problem hiding this comment.
Looks good. Just some small clean ups.
Also, is there a benchmark that exercises that code that we can check to make sure it's fine?
fortuna
approved these changes
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of keeping track of a diff of ports to keep open, we introduce reusable listeners that can be hot-swapped by remaining open until the last user of the listener closes it.
This pulls out the listener changes from #182, which is focused on adding a new config format.