refactor: move to a new "Service" config format#182
Merged
Conversation
Author
|
@fortuna PTAL while I'm out. I'll pick it back up once I'm back next week. |
juev
reviewed
Jun 4, 2024
juev
left a comment
There was a problem hiding this comment.
A very good point is that ports are now used as they are described in the configuration file.
fortuna
reviewed
Jun 10, 2024
fortuna
reviewed
Jun 10, 2024
fortuna
requested changes
Jun 10, 2024
707bc35 to
80e5d49
Compare
Author
|
@fortuna PTAL now that the listener changes have been merged |
fortuna
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduce a concept of a
Service. Services listen on an address and accept a set of ciphers. This generalization allows us to move away from a single port->cipher map.