Skip to content

Update strings for keyboard shortcuts#10399

Merged
SoftFever merged 1 commit intoOrcaSlicer:mainfrom
afmenez:keyb_shortcuts
Sep 9, 2025
Merged

Update strings for keyboard shortcuts#10399
SoftFever merged 1 commit intoOrcaSlicer:mainfrom
afmenez:keyb_shortcuts

Conversation

@afmenez
Copy link
Copy Markdown
Contributor

@afmenez afmenez commented Aug 13, 2025

Description

  • Split keyboard shortcuts into components, to simplify translations
  • Added missing translation markers to keyboard shortcuts

@afmenez afmenez force-pushed the keyb_shortcuts branch 4 times, most recently from e46fedf to c253532 Compare August 17, 2025 23:44
@afmenez
Copy link
Copy Markdown
Contributor Author

afmenez commented Aug 17, 2025

Rebased to main.

@afmenez afmenez force-pushed the keyb_shortcuts branch 2 times, most recently from 92201e2 to a2ec8d3 Compare August 26, 2025 21:15
@afmenez
Copy link
Copy Markdown
Contributor Author

afmenez commented Aug 26, 2025

Rebased to main to fix merge conflicts.

@afmenez
Copy link
Copy Markdown
Contributor Author

afmenez commented Sep 7, 2025

Rebased and added markers to "Backspace" too.

@SoftFever
Copy link
Copy Markdown
Collaborator

@afmenez
Thank you for your continued efforts.
Regarding the changes in this PR, I believe they are not strictly necessary.
They appear to be more personal preferences rather than bug fixes or improvements.
To avoid unnecessary changes in the Git history, I would prefer not to include them.
I appreciate your contribution.

@afmenez
Copy link
Copy Markdown
Contributor Author

afmenez commented Sep 9, 2025

@SoftFever, this patch solves real issues for translators:

  • Some instances of the key names were not marked for translation;
  • Some key names were spelled in different ways ("Alt+" and "Alt +"), causing the need to translate the same name more than once;
  • Each key combination ("Shift+A" and "Shift+Q" ) needed to be translated separately, now only the key names need to be translated once;

@afmenez
Copy link
Copy Markdown
Contributor Author

afmenez commented Sep 9, 2025

Rebased to main to fix merge conflicts.

Copy link
Copy Markdown
Collaborator

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. It makes sense now. Thanks!

@SoftFever SoftFever merged commit 914425e into OrcaSlicer:main Sep 9, 2025
13 checks passed
ianalexis pushed a commit to ianalexis/OrcaSlicer that referenced this pull request Sep 9, 2025
* Update strings for keyboard shortcuts
@afmenez afmenez deleted the keyb_shortcuts branch September 10, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants