Default processes to empty array instead of leaving unassigned in driver detection #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonX
previously approved these changes
Oct 13, 2025
Member
gonX
left a comment
There was a problem hiding this comment.
LGTM, since we should be able to assume that Processes are now no longer null.
gonX
approved these changes
Oct 13, 2025
Member
gonX
left a comment
There was a problem hiding this comment.
Additional change makes sense, still LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate for fixing #4228
Tested and working for me. Windows already sets them to an empty array when no processes are found.
Related: #4230