[06x] Fix NRE in safeGetProcessDetails usage
#4230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the array provided to the function is empty, it will not return anything. Changing the type indicates this behavior better, and should allow code analysis to catch misuse of this function
Member
Author
|
Closing as this is nonsense. Testing an static IEnumerable<string> testFunc()
{
if (0>1)
yield return "Math has failed us";
}
Console.WriteLine(testFunc());
foreach (var x in testFunc())
{
Console.WriteLine("looping");
Console.WriteLine(x);
}outputs: ie. it is never null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the type hint of the function to be nullable, which should help expose misuse of the function type. It also adds a null check before running the code.
Fixes #4228 and might need to be cherry-picked into a hotfix patch since this breaks the driver completely for anyone with a kernel driver loaded on at least Linux.