Add the "Lords Mobile" edition of the H950P #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Lords Mobile" edition of the H950P has a different ProductID than the standard H950P. Adding this identifier allows the "Lords" version to function the same as the standard H950P.
jamesbt365
requested changes
Aug 6, 2024
Member
jamesbt365
left a comment
There was a problem hiding this comment.
Could you post the diagnostics and string dump files please? This is required for all configurations and is outlined in our CONTRIBUTING.md.
OpenTabletDriver.Configurations/Configurations/Huion/H950P.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Attached are the string dump and output from otd-daemon. |
Member
|
Diagnostics must be from the inbuilt diagnostics tool. |
Contributor
Author
|
Apologies, here are the correct diagnostics. |
Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
jamesbt365
approved these changes
Aug 6, 2024
Member
|
Thanks for the contribution! |
2 tasks
VoidJuiceConcentrate
pushed a commit
to VoidJuiceConcentrate/OpenTabletDriver
that referenced
this pull request
Aug 26, 2024
Add the "Lords Mobile" edition of the H950P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Lords Mobile" edition of the H950P has a different ProductID than the standard H950P. Adding this identifier allows the "Lords" version to function the same as the standard H950P.
Looking for feedback as well about whether or not this is appropriate as an addition to the current H950P.json or if it should be its own file. As it stands, the model number on the back states the tablet is an "H950P" with the only difference I noticed is the ProductID.
Diagnostics:
https://github.com/user-attachments/files/16515015/H950P_Lords.txt
String Dump:
https://github.com/user-attachments/files/16514947/H950P_Lords.txt
Verification:
I have successfully used the tablet in Krita and mapped functions to all pen buttons and auxiliary buttons on the tablet.