Attribute overhaul #3245
Attribute overhaul #3245
Conversation
|
Probably a bit late that I thought of this, but wouldn't the attribute better be defined as a new property in the digitizer identifier? |
This probably isn't the best case considering improving the detection scheme further would add extra attributes, putting extra filters in place. See #3011 for what else could be added in the future. |
|
#3276 requires Interface 0, there are 3 interfaces all with the same input and output lengths. |
|
Will rebase this PR and backport it when we close in on the next release and merge some configurations, its not fair on others to rebase 70+ configuration pull requests because i changed the configuration format. |
|
I'm not actually sure if using the existing code is the best idea, looking at some of the comments internally i'm not sure the information is available for every identifier (whereas it is always in the device path) I know @X9VoiD implemented this stuff so I'd like his opinion on it. |
|
Will revert the latest commit and put a note in to use existing stuff when its reliable with WinUSB and anything else we add support for later. Then I'll rebase and fix conflicts. |
|
We still need to not require the new Attribute field on all configs. |
Turns out we have had this for a while, just in a different file out of sight.
…dard This was changed with OpenTabletDriver/OpenTabletDriver#3245 (3d887e6cf638031d5ab762f95a24e1e8071ddd2b)
Supersedes #3243.
Fixes #2438.
TODO:
FeatureInitDelayMsattribute.DigitizerIdentifiers.I have something I'm not the most sure on right now, should a method be implemented somewhere to get the combined attributes? Right now it has absolutely no demand and its not complex logic to begin with, and use for combined attributes only are required in one spot, so its not like any code duplication will happen if we don't implement one.
At this time I'm not going to add support for FeatureInitDelayMs or libinputoverride in specific device identifiers, this is not needed and just increases complexity, but implementing the above would amend that. But considering the usage of delay (only intuos3 and on ALL tablets regardless of identifier) there is absolutely no need to implement support into the identifiers too.
Reminder to submit a pull request for web once this is merged.