Skip to content

[Backport] Fix UC-Logic 1060N configuration #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gonX merged 1 commit into from
Dec 14, 2024
Merged

[Backport] Fix UC-Logic 1060N configuration #3239

gonX merged 1 commit into from
Dec 14, 2024

Conversation

@jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Mar 11, 2024 •
edited
Loading

Backport of #3238.

@jamesbt365 jamesbt365 added the configuration Adds or modifies a tablet configuration label Mar 12, 2024
@jamesbt365 jamesbt365 marked this pull request as draft April 4, 2024 19:07
@jamesbt365 jamesbt365 added this to the v0.6.5 milestone Aug 25, 2024
@jamesbt365
Fix UC-Logic 1060N configuration.
e9b5a9e 
No verification was ever done on pressure and considering the age of
this tablet I'm guessing it was plain wrong to begin with, so I've
corrected the value to 2047. See #1037 for the original implementation.

When the configuration was "fixed" originally, it ended up "fixing" it
to work with with a version with broken firmware. We should not be
accomodating configurations for broken firmware, as this leaves genuine
users in the dirt.
@jamesbt365 jamesbt365 marked this pull request as ready for review December 14, 2024 16:06
Kuuuube
Kuuuube approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gonX
Copy link
Member

gonX commented Dec 14, 2024

Merging given Kuuuube's approval

@gonX gonX merged commit 7487c28 into OpenTabletDriver:0.6.x Dec 14, 2024
8 checks passed
@gonX gonX added the forward-port-not-needed Feature is already implemented, is not relevant, or is considered elsewhere for Avalonia branch label Oct 2, 2025
@Kuuuube Kuuuube mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

Assignees

No one assigned

Labels

configuration Adds or modifies a tablet configuration forward-port-not-needed Feature is already implemented, is not relevant, or is considered elsewhere for Avalonia branch

Projects

None yet

Milestone

v0.6.5

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesbt365 @gonX @Kuuuube