Fix UC-Logic 1060N configuration #3238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The PR body is a mess at this point so to clarify what this actually does.
I will rebase and undraft when I get clarification on if this change is okay. |
5 tasks
No verification was ever done on pressure and considering the age of this tablet I'm guessing it was plain wrong to begin with, so I've corrected the value to 2047. See #1037 for the original implementation. When the configuration was "fixed" originally, it ended up "fixing" it to work with with a version with broken firmware. We should not be accomodating configurations for broken firmware, as this leaves genuine users in the dirt.
Kuuuube
approved these changes
Dec 14, 2024
Member
|
Merged the 0.6.x one, so merging this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3237.
I don't think we had concrete evidence of this configuration working to begin with.
No verification was ever done on pressure and considering the age of this tablet I'm guessing it was plain wrong to begin with, so I've corrected the value to 2047. See #1037 for the original implementation.
Somewhere between the original pull request mentioned above and now the
OutputReportLengthwas set to null, which is wrong because multiple interfaces have theInputReportLengthof 8, which at a minimum breaks support for Linux and possibly MacOS.Edit: looking into this further, this reverts changes from #1721, but without reverting this it introduces RNG into weather or not the tablet wants to work, but no logs were provided there, so I'm not sure what the actual approach should be here.
Edit2: looking into this further, they are forcing their tablet to use interface 0, which I don't believe is right? I've seen 2 tablets using the exact same configuration with the exact same device strings, unless this is a different variant i don't see why its using interface 0 and instead of interface 2, and why it needs null instead of 8.
Regardless using null is not always a brilliant idea....