Add Gaomon GM116HD #2901
Merged
Add Gaomon GM116HD #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values extrapolated from GM156HD, and confirmed with real tablet
jamesbt365
requested changes
Aug 24, 2023
Member
jamesbt365
left a comment
There was a problem hiding this comment.
Please convert to the configuration format seen in master.
jamesbt365
reviewed
Aug 24, 2023
OpenTabletDriver.Configurations/Configurations/Gaomon/GM116HD.json
Outdated
Show resolved
Hide resolved
jamesbt365
reviewed
Aug 24, 2023
OpenTabletDriver.Configurations/Configurations/Gaomon/GM116HD.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Updated values (the previous one was taken from a reseller's website and it was slightly off, changed to official values) |
jamesbt365
reviewed
Aug 24, 2023
Member
jamesbt365
left a comment
There was a problem hiding this comment.
Good to go once a diagnostic is provided with the tablet plugged in and working and the tablet is added to the tablets.md in the root of the directory.
Contributor
Author
|
diagnostics.txt |
jamesbt365
approved these changes
Aug 26, 2023
Member
|
@InfinityGhost CI is stuck here again, I can't bypass the checks to merge this. |
Kuuuube
added a commit
to Kuuuube/OpenTabletDriver
that referenced
this pull request
Nov 21, 2023
Co-authored-by: Long Nguyen <nguyen.long.908132@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values extrapolated from GM156HD, and confirmed with real tablet.