Add confidence threshold to camera adjuster#19
Merged
lukasalexanderweber merged 2 commits intoOpenStitching:mainfrom Aug 8, 2022
Merged
Add confidence threshold to camera adjuster#19lukasalexanderweber merged 2 commits intoOpenStitching:mainfrom
lukasalexanderweber merged 2 commits intoOpenStitching:mainfrom
Conversation
Member
|
Oh wow now it completely makes sense why the stitching failed for me several times during adjusting when I lowered the threshold. I never realized this, eventually I always ended up setting thanks also for the black formatting, it comes from here which was rather a quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of my tests, I was getting the occasional match between two images that was just below the default confidence threshold (e.g. 0.9 or so). When setting the confidence threshold lower, I noticed this gave markedly worse results – even matches with confidence 0.98 completely failed to stitch. It was only digging into the C++ code I realised that the camera adjuster completely skips matches with a confidence below its own confidence threshold setting, which was always set to 1.0 in
camera_adjuster.py. This PR re-uses the same confidence threshold that is passed into the subsetter for the camera adjuster, which greatly improves the results on lower confidence matches.(Also, as part of running the pre-commit hooks, the black formatter also updated some single quotes to double quotes in
stitcher.py!)