Skip to content

Remove invalid nfeature arg for brisk and akaze#18

Merged
lukasalexanderweber merged 4 commits intoOpenStitching:mainfrom
hoogenm:main
Aug 3, 2022
Merged

Remove invalid nfeature arg for brisk and akaze#18
lukasalexanderweber merged 4 commits intoOpenStitching:mainfrom
hoogenm:main

Conversation

@hoogenm
Copy link
Copy Markdown
Contributor

@hoogenm hoogenm commented Aug 3, 2022

The FeatureDetector gave an error when invoked with detector brisk or akaze and the (default) parameter of nfeatures. The PR will make the feature detector disregard nfeatures if detector is brisk or akaze.

@lukasalexanderweber
Copy link
Copy Markdown
Member

I would prefer this sollution since I can document it in the help. Is this fine for you?

@hoogenm
Copy link
Copy Markdown
Contributor Author

hoogenm commented Aug 3, 2022

Sure, thank you!

@hoogenm hoogenm closed this Aug 3, 2022
@lukasalexanderweber lukasalexanderweber merged commit ecad88b into OpenStitching:main Aug 3, 2022
@lukasalexanderweber
Copy link
Copy Markdown
Member

thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants