Merged
Conversation
* Fix user presenter for user groups (decidim#4973) * Fix user presenter for user groups The user groups do not have a `.deleted?` method defined for them which caused the user presenter to break the notifications view in case the notification was linking to a group user. * Add CHANGELOG entry * Fix changelog
- reverting 25bd9a4 - reverting 7b6f2e5 - better fix comes from decidim@7372946
lu-hamani
suggested changes
Mar 19, 2019
lu-hamani
left a comment
There was a problem hiding this comment.
#525 and #488 are fixed. Translation from "Titre" to "Pages" is also good.
#538 didn't go through
There is also some minor issues left regarding #532 :
The links that enable a user to unfollow a proposal or its author are broken. The redirect urls are incomplete as shown in the following screenshots.
Link to proposal
Link to author's profile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managing Weekly Issues for Week #11 :
• [BACKPORT] Fix user presenter for user groups (decidim#4974)
• 🐛 ⏪ Better fixes for #525 …
• 🌐 amendable event FR label #532
• 🐛 HashtagRenderer in comment events #532
• 🐛 fix step_cta_path #488
• 🌐 [pages] FR "Titre" >> "Page" !
• Change default trad on CTA button ParticiperLOL #538