[BACKPORT] Fix user presenter for user groups (#4974)

mrcasals · oriolgual · commit 7372946d74f8 · 2019-03-18T09:14:47.000+01:00
* Fix user presenter for user groups (#4973) * Fix user presenter for user groups The user groups do not have a `.deleted?` method defined for them which caused the user presenter to break the notifications view in case the notification was linking to a group user. * Add CHANGELOG entry * Fix changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Upgrade notes
 
 #### User follow counters
+
 After running the migrations, please run this code from a console:
 
 ```ruby
@@ -62,7 +63,6 @@ end
 - **decidim-proposals** Don't count withdrawn proposals when publishing one [\#4875](https://github.com/decidim/decidim/pull/4875)
 - **decidim-core**: Fix process filters [\#4872](https://github.com/decidim/decidim/pull/4872)
 
-
 ## [0.16.0](https://github.com/decidim/decidim/tree/v0.16.0)
 
 **Upgrade notes**:
@@ -264,6 +264,7 @@ In order to generate Open Data exports you should add this to your crontab or re
 - **decidim-core**: Speed up `AddFollowingAndFollowersCountersToUsers` migration [\#4955](https://github.com/decidim/decidim/pull/4955/)
 - **decidim-admin**: Let admins visit the autrhorization workflows index page [\#4963](https://github.com/decidim/decidim/pull/4963/)
 - **decidim-admin**: Do not generate profile URL in officializations view if nickname is missing [\#4962](https://github.com/decidim/decidim/pull/4962/)
+- **decidim-core**: Fix user presenter for user groups breaking notifications views [\#4973](https://github.com/decidim/decidim/pull/4973/)
 
 **Removed**:
 
diff --git a/decidim-core/app/presenters/decidim/user_presenter.rb b/decidim-core/app/presenters/decidim/user_presenter.rb
@@ -25,13 +25,13 @@ def badge
     delegate :url, to: :avatar, prefix: true
 
     def profile_url
-      return "" if deleted?
+      return "" if respond_to?(:deleted?) && deleted?
 
       decidim.profile_url(__getobj__.nickname, host: __getobj__.organization.host)
     end
 
     def profile_path
-      return "" if deleted?
+      return "" if respond_to?(:deleted?) && deleted?
 
       decidim.profile_path(__getobj__.nickname)
     end
diff --git a/decidim-core/spec/presenters/decidim/user_presenter_spec.rb b/decidim-core/spec/presenters/decidim/user_presenter_spec.rb
@@ -55,5 +55,23 @@ module Decidim
           have_selector(".user-mention")
       end
     end
+
+    context "when user is a group" do
+      let(:user) { build(:user_group) }
+
+      describe "#profile_path" do
+        subject { described_class.new(user).profile_path }
+
+        it { is_expected.to eq("/profiles/#{user.nickname}") }
+      end
+
+      describe "#profile_url" do
+        subject { described_class.new(user).profile_url }
+
+        let(:host) { user.organization.host }
+
+        it { is_expected.to eq("http://#{host}/profiles/#{user.nickname}") }
+      end
+    end
   end
 end
