Add music track listing to ride music window#20980
Conversation
|
This looks really good! Great work! There's a few things that I'd recommend changing, they are mostly alignment issues. Line up the top of the image with the Play Music icon (currently it's centered with the Tracklist, but the user won't expand this often enough to look proper) , this will also allow the author to be on a singular line, rather than taking up three lines. The image is missing it's outline as seen in for example the object selector. This has to be re-added to allign with ui's standard. (It currently pops out, but it has to be inside a frame: the bottom is lighter and the top is darker). I will make sure to playtest this right away and will leave another comment afterwards. |
Just updated the code. It looks much cleaner now. Any more feedback is appreciated! :) |
|
@karst do we want to add some string like "Composers" or "Performers" or something? |
|
I don't think that's necessary. Most songs seperate artist from song using just a dash, which makes that clear enough. Perhaps we should update the music objects to include Allister Brimble where necessary. |
|
Would it be possible to hide the scroll bars from the track list if there's no need to scroll? Right now this tab seems very cluttered. 🥴 |
|
I was thinking, |
Working on this now. |
|
This pull request has been marked as stale and will be closed in 14 days if no action is taken. To keep it open, leave a comment or remove the |
|
Going over stale PRs, I came across this one. To be honest, I think this adds a lot of clutter to the UI. Thinking about it, I believe this has to do with seeing boldface black text on a red window. Perhaps it would look better using the 'Small' font style, rather than the default 'Medium' one? @karst, what do you think? Aside from the UI, I think the code needs a bit of cleaning up before this is ready to be merged. Considering how long this PR has been sitting for, I'm willing to take it to the finish line myself if need be, though. |
|
The smaller text, which you've shown in the screenshot definitely looks cleaner. The author on the bottom no longer needs to be shown there anymore since each song has it's componist listed since a few months now. |
|
After some discussion with @Gymnasiast on Discord, we agreed it would be best to push the preview image down a little, such that it aligned horizontally with the track list. This would provide ample room for a future button next to the music dropdown above. Here's a few screenshots with the current status as the rewrites I've pushed. |
|
Very nice, perhaps push the full window down by one or two more pixels so the resize icon doesn't overlap with other buttons? |
Urgh, this was due a race condition inherent to the widget definitions being shared globally. I've added a hack to counter this. @karst If you're happy with the PR in its current state, I think it's ready to be merged. Just needs a changelog entry and we're good to go. |










Applies issue #20832. Adds music object data (track names, authors and preview images) to the ride music window.