Clean up PaintAddImageAsParentRotated() function and calls#19390
Merged
duncanspumpkin merged 2 commits intoFeb 13, 2023
Conversation
71af161 to
38b057a
Compare
duncanspumpkin
approved these changes
Feb 13, 2023
Contributor
|
Looks sensible enough. For anyone wondering was done with a regex to move the params into the bbox struct. |
karst
added a commit
to karst/OpenRCT2
that referenced
this pull request
Feb 14, 2023
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the PaintAddImageAsParentRotated() functions to two. One "main" function, and one helper function that allows omitting the bound box offset (taking the regular offset as the bound box offset).
Calls to PaintAddImageAsParentRotated() that used separate CoordsXYZ for the boundbox offset and size have all been autoreplaced using a regular expression. This makes the diff rather big, but due to the automatic nature I expect reviewing a few files to be sufficient.