Disable the SkyLakeX DGEMMIxCOPY kernels as well#2111
Merged
martin-frbg merged 2 commits intoOpenMathLib:developfrom May 5, 2019
martin-frbg:issue1955
Merged
Disable the SkyLakeX DGEMMIxCOPY kernels as well#2111martin-frbg merged 2 commits intoOpenMathLib:developfrom martin-frbg:issue1955
martin-frbg merged 2 commits intoOpenMathLib:developfrom
martin-frbg:issue1955
Conversation
as a stopgap measure for numpy/numpy#13401 as mentioned in #1955
isuruf
reviewed
May 5, 2019
|
|
||
| DGEMMINCOPY = dgemm_ncopy_8_skylakex.c | ||
| DGEMMITCOPY = dgemm_tcopy_8_skylakex.c | ||
| #DGEMMITCOPY = dgemm_tcopy_8_skylakex.c |
Contributor
There was a problem hiding this comment.
I'm not familiar with the code base. Can you explain what gemm_tcopy_8 does and how it's different from gemm_tcopy_4?
Contributor
There was a problem hiding this comment.
that one takes four elements of input at a time and other eight. 4x8 would mean taking that big rectangular block from input.
Contributor
There was a problem hiding this comment.
Doesn't that mean DGEMMINCOPY and DGEMMITCOPY both need to be gemm_*copy_4 variants instead of gemm_*copy_8 variants?
Contributor
|
Cool--note that an earlier version of Maybe some kind of weird behavior with partial disable of the problematic kernels? |
isuruf
added a commit
to isuruf/openblas-feedstock
that referenced
this pull request
May 11, 2019
isuruf
added a commit
to conda-forge/openblas-feedstock
that referenced
this pull request
May 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a stopgap measure for numpy/numpy#13401 as mentioned in #1955