The reverb feature appears to cause the game to crash if it is built with the Debug solution configuration.
There is a debug assertion failed pop up when the game is loading, and the game stops the moment any audio is going to play (including the title music).
This does not happen if I disable the reverb by removing the line of code that sets _reverbAvailable. It also does not happen if I build the game using the Release configuration.

When a vehicle2 is imported, its sound.audioHandle is 0. updateVehicleNoise() then destroys any audio that was using audio handle 0. Thus, when the title sequence is first loaded, the title music gets killed.

This should address all the comments, the assertion is an OpenAL bug which is already fixed upstream so we have to wait for a release and updated vcpkg port, since its only a debug assertion I guarded the reverb code under NDEBUG, the code is technically functional and since we ship Release builds this has to do for now.

all but the bottom thumb are cut off on the bottom pixel - need more vertical spacing between sliders:

this was always a pet peeve of mine - but lowering the slider to the lowest setting does not mute the channel as expected. this is vanilla behaviour because the sliders directly work with decibels instead of a linear range of 0-100 (or whatever). would be great to fix that if possible here

i think the tooltip colours can be improved:

i think the tooltip colours can be improved:

The last commit should do that

this was always a pet peeve of mine - but lowering the slider to the lowest setting does not mute the channel as expected. this is vanilla behaviour because the sliders directly work with decibels instead of a linear range of 0-100 (or whatever). would be great to fix that if possible here

Hmm, will have look into it.

Vehicle sounds now continue playing infinitely if a vehicle is on your screen and you load a game, and when the title sequence loops.

Less importantly, vehicle sounds also now play when the load game browse prompt is open, which they did not in 26.02 (This one was already present before my first reviews to be clear)

I see you fixed the vehicle and ambient noises for PromptBrowseWindow and PromptOkCancel, but I noticed that you have missed (at least):

• PromptSave (the 'are you sure you want to quit' prompt, which can be difficult to see especially if you have autosaving enabled), and
• ObjectSelectionWindow (as it nowdays pauses the game when opened during play mode).

I suggest a more robust solution would probably be to stop the sounds when any pause flag is set (Related: #3185).

Vehicle sounds now continue playing infinitely if a vehicle is on your screen and you load a game, and when the title sequence loops.

Looks (well, sounds) that this has been fixed 😄

Difference from master: If the selected sound device is not plugged in when you start the game, the game now fails to open the sound device instead of incorrectly(?) playing audio from a different device. This fixes #3632 (maybe not in an ideal way, but this is probably not a priority anyway).

Also fixes a small bug that I don't think an issue was made for, where the dropdown could display "Default sound device" when it shouldn't, and look bugged when partially invalidated.

I see you fixed the vehicle and ambient noises for PromptBrowseWindow and PromptOkCancel, but I noticed that you have missed (at least):

• PromptSave (the 'are you sure you want to quit' prompt, which can be difficult to see especially if you have autosaving enabled), and
• ObjectSelectionWindow (as it nowdays pauses the game when opened during play mode).

I suggest a more robust solution would probably be to stop the sounds when any pause flag is set (Related: #3185).

I fixed this, the issue was not of a missing pauseSound call but the update function ignoring the paused state. I will leave this now as is, it should work correctly. I want to refactor the entire state flow at some point, its pretty spaghetti currently, things are happening all over the place.

If that is the last of the issues I will commit the changelog entries.