Add onPause() and onUnpause() - fix music resuming after saving when paused#3185
Open
LeeSpork wants to merge 12 commits intoOpenLoco:masterfrom
Open
Add onPause() and onUnpause() - fix music resuming after saving when paused#3185LeeSpork wants to merge 12 commits intoOpenLoco:masterfrom
LeeSpork wants to merge 12 commits intoOpenLoco:masterfrom
Conversation
Contributor
Author
|
This will be made redundant if #3187 is merged. |
LeeSpork
commented
Aug 9, 2025
| static void onPause() | ||
| { | ||
| Audio::pauseSound(); | ||
| Ui::Windows::TimePanel::invalidateFrame(); |
Contributor
Author
There was a problem hiding this comment.
GameCommands.cpp and PromptSaveWindow.cpp used
WindowManager::invalidate(WindowType::timeToolbar);
while TogglePause.cpp used
Ui::Windows::TimePanel::invalidateFrame();
Those appear to be two different ways of achieving the same result. I went with the latter because it did not require adding an additional include to this file.
LeeSpork
commented
Aug 23, 2025
A new way that the bug occurs was added since this pull request was first made. Now it is accounted for as well.
ZehMatt
reviewed
Jan 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicates code and fixes #3183 by adding
onPause()andonUnpause()to SceneManager.cpp (let me know if there is a better place to put them), which are only called when the game is actually fully unpaused, or paused from being fully unpaused.