Make music options accessible on title screen#3326
Merged
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom Oct 19, 2025
Merged
Make music options accessible on title screen#3326AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
Conversation
- Only show title music name when playing title music - Check isPlayMode() so that this will also work on scenario editor (though that does not need music options) - Currently playing dropdown is drawn disabled
Contributor
Author
|
Now it defaults to "None" if the title music is disabled. I also properly disabled the drop-down, which makes the text look disabled (which I'm not 100% sure on). |
AaronVanGeffen
approved these changes
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The music tab is no longer disabled when in the title screen. This allows the user to adjust the volume of the (title screen) music -
closes #1625.
The music controls are of course grayed out. I also took the liberty of putting the name of the titlescreen music (sourced from the about window) where it displays the currently playing track.
Limitation: there is (still) no way to toggle if music should be played whilst playing a scenario from the title screen.
The Sound and Music tabs should be merged into one tab in the future, as it no longer makes much sense for the Play title screen music checkbox to be in the former. I figure that should be in a later pull, so that discussion on this one can be more focused on how the music control widgets are displayed on the title screen.