TimePanel.cpp - remove loco global and invalidate less#3194
Merged
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom Oct 5, 2025
Merged
TimePanel.cpp - remove loco global and invalidate less#3194AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 6 commits intoOpenLoco:masterfrom
Conversation
| } | ||
|
|
||
| if (SceneManager::isPaused()) | ||
| if (frameInvalid || (SceneManager::isPaused() && (w.numTicksVisible == 30 || w.numTicksVisible == 0))) |
Contributor
There was a problem hiding this comment.
what is this (w.numTicksVisible == 30 || w.numTicksVisible == 0)?
Contributor
Author
There was a problem hiding this comment.
Those are the two moments that the time panel actually needs to be invalidated while paused, to change whether it shows "* paused *" or the date.
AaronVanGeffen
approved these changes
Oct 1, 2025
Member
AaronVanGeffen
left a comment
There was a problem hiding this comment.
Looks like this is working fine.
LeeSpork
added a commit
to LeeSpork/OpenLoco
that referenced
this pull request
Oct 5, 2025
LeeSpork
added a commit
to LeeSpork/OpenLoco
that referenced
this pull request
Oct 27, 2025
LeeSpork
added a commit
to LeeSpork/OpenLoco
that referenced
this pull request
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.