Create and use PauseFlags enum#3186
Merged
AaronVanGeffen merged 9 commits intoOpenLoco:masterfrom Dec 6, 2025
Merged
Conversation
Contributor
Author
|
Implemented all review comments thus far 👍 |
Contributor
Author
|
This will be made redundant if #3187 is merged. |
adb1cdf to
c411bb9
Compare
c411bb9 to
e36b397
Compare
Contributor
Author
|
Updated |
4a6a0c6 to
29a72f4
Compare
Member
|
Could you rebase this and add a named flag for the new object selection pause flag? |
I believe this is a more accurate and useful name.
29a72f4 to
159565b
Compare
Oversight I made in resolving conflicts in the rebase
Contributor
Author
|
Done. (I also sneaked in changing my mind on what I called flag 1) |
ZehMatt
approved these changes
Dec 6, 2025
AaronVanGeffen
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toggle pause game command now works properly even if the game is also paused by a different flag (though it may not be currently possible to experience this in normal gameplay anyway). Otherwise, the behaviour should be unchanged.