refactor confirmResetLandscape() and delete LandscapeGenerationConfirm window#3105
Merged
AaronVanGeffen merged 7 commits intoOpenLoco:masterfrom Jul 25, 2025
Merged
Conversation
b728028 to
a20b0ab
Compare
Member
AaronVanGeffen
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3104
There is one user-facing change: the confirmation dialogue is now a modal window (you are no longer able to click outside of it until you answer it). (This is a change from original Locomotion behaviour, arguable if it counts as a vanilla-bug/oversight)
Comparison screenshots showing that the result appears identical to before:
v25.04:
PR:
