Implement OpenLoco::Scenario::sub_4748D4 (0x004748D4)#3164
Merged
AaronVanGeffen merged 2 commits intoOpenLoco:masterfrom Jul 25, 2025
Merged
Implement OpenLoco::Scenario::sub_4748D4 (0x004748D4)#3164AaronVanGeffen merged 2 commits intoOpenLoco:masterfrom
AaronVanGeffen merged 2 commits intoOpenLoco:masterfrom
Conversation
duncanspumpkin
approved these changes
Jul 25, 2025
Member
|
This appears to cause the landscape generation function to crash immediately. I'll investigate. |
| ObjectManager::sub_47966E(); | ||
| ObjectManager::updateDefaultLevelCrossingType(); | ||
| ObjectManager::sub_47AC05(); | ||
| CompanyManager::sub_4A6DA9(); |
Member
There was a problem hiding this comment.
If I replace this line with call(0x004A6DA9); the crash goes away. This suggests the issue is with #3084, and the current PR has only made the issue visible. Let's continue conversation there.
Contributor
Author
There was a problem hiding this comment.
Is it still crashing after your changes? Or is it fixed now?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.