Update docker_runtime.py #8422#8423
Merged
enyst merged 1 commit intoOpenHands:mainfrom May 10, 2025
Merged
Conversation
Closed
1 task
shabbir-shakudo
pushed a commit
to devsentient/OpenHands
that referenced
this pull request
Jul 15, 2025
shanemort1982
pushed a commit
to shanemort1982/OpenHands
that referenced
this pull request
Dec 20, 2025
…ntainers When accessing OpenHands from a remote browser, WebSocket connections fail because URLs use 'localhost' instead of the actual server IP address. Root cause: The DOCKER_HOST_ADDR environment variable is not passed from the main OpenHands container to spawned runtime containers, causing them to default to localhost for URL construction. This fix ensures that DOCKER_HOST_ADDR is inherited by runtime containers, allowing existing code in sandbox_config.py and docker_runtime.py to correctly use the server IP for WebSocket and API URLs. Fixes remote access scenarios where browser and server are on different machines. Related to OpenHands#8423 (previous fix for old architecture)
shanemort1982
pushed a commit
to shanemort1982/OpenHands
that referenced
this pull request
Dec 22, 2025
…ntainers When accessing OpenHands from a remote browser, WebSocket connections fail because URLs use 'localhost' instead of the actual server IP address. Root cause: The DOCKER_HOST_ADDR environment variable is not passed from the main OpenHands container to spawned runtime containers, causing them to default to localhost for URL construction. This fix ensures that DOCKER_HOST_ADDR is inherited by runtime containers, allowing existing code in sandbox_config.py and docker_runtime.py to correctly use the server IP for WebSocket and API URLs. Fixes remote access scenarios where browser and server are on different machines. Related to OpenHands#8423 (previous fix for old architecture)
|
As of march 2026, the localhost issue persists! Just commented at the root issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8422
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Link of any specific issues this addresses: