Move Tavily search key to MCP settings by neubig · Pull Request #14000 · OpenHands/OpenHands

neubig · 2026-04-17T14:57:27Z

Human: I have now QAed this and confirmed that it fixes #13969

Summary

move the Tavily search_api_key UI out of LLM settings and into a dedicated MCP settings section
keep LLM settings saves scoped to LLM-owned fields so they no longer clear the MCP-owned Tavily key
add regression coverage for the MCP Tavily save flow and for the LLM page no longer rendering or updating the Tavily field

Testing

cd frontend && npm run test -- tests/routes/llm-settings.test.tsx tests/routes/mcp-settings.test.tsx
cd frontend && npm run lint:fix && npm run build

Fixes #13969

AI-generated draft PR created by OpenHands on behalf of the user.

GIF artifacts

MCP settings screenshot
Captured from a local make run session showing the general MCP server pane above the built-in Tavily search pane.

Tavily repro GIF
Labeled before/after reproduction showing the bug on main and the MCP-owned Tavily key surviving LLM saves on this branch.

To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.openhands.dev/openhands/runtime:778cf13-nikolaik   --name openhands-app-778cf13   docker.openhands.dev/openhands/openhands:778cf13

Co-authored-by: openhands <openhands@all-hands.dev>

github-actions · 2026-04-17T15:06:18Z

Coverage report

This PR does not seem to contain any modification to coverable code.

Co-authored-by: openhands <openhands@all-hands.dev>

github-actions · 2026-04-17T16:17:45Z

✅ PR Artifacts Cleaned Up

The .pr/ directory has been automatically removed.

Co-authored-by: openhands <openhands@all-hands.dev>

all-hands-bot

🟢 Good taste - Clean architectural separation that fixes a real bug. The Tavily search key now lives in MCP settings where it belongs, preventing accidental clearing when saving LLM settings.

[RISK ASSESSMENT]

[Overall PR] ⚠️ Risk Assessment: 🟢 LOW

Pure frontend refactoring with no backend changes, good test coverage, and backward compatibility. Fixes a real bug where LLM settings saves were clearing the MCP-owned Tavily key.

VERDICT:
✅ Worth merging - Solid architecture, well tested, solves real problem

KEY INSIGHT:
Moving ownership boundaries from implementation (which fields to save) to UI structure (which page owns which settings) prevents accidental data loss and makes the codebase more maintainable.

all-hands-bot · 2026-04-17T17:57:06Z

            llm: expect.objectContaining({ api_key: "test-api-key" }),
          }),
        }),
      );


🟡 Suggestion: Consider adding a comment explaining why search_api_key persists after save despite not being in the payload:

// Backend preserves MCP-owned fields (like search_api_key) even when // LLM settings save doesn't include them const payload = saveSettingsSpy.mock.calls[0]?.[0] as Record<string, unknown>; expect(payload).not.toHaveProperty("search_api_key");

This makes the test's intent clearer - we're verifying the frontend correctly scopes LLM saves to LLM-owned fields.

neubig · 2026-04-18T02:03:16Z

@OpenHands move the general mcp pane above the tavily pane, and make sure you share a screenshot of the updated design

openhands-ai · 2026-04-18T02:03:57Z

I'm on it! neubig can track my progress at all-hands.dev

neubig · 2026-04-18T02:09:06Z

Done! Ive reordered the MCP settings page so the general MCP server list pane now appears above the Tavily search settings pane.

Updated order:

Header with title/description and "Add Server" button
General MCP Servers (list of SSE, stdio, shttp servers) ← moved up
Tavily Search API Key (search_api_key settings) ← moved down

Changes committed in: 8d03464

The Docker container ran into issues in this environment so Im unable to capture a live screenshot, but the code change is straightforward and the build passes. Let me know if youd like me to try a different approach to get a screenshot, or if the code change looks good to merge.

openhands-ai · 2026-04-18T02:09:46Z

Summary of Work

I addressed the PR review comment on #14000 asking to move the general MCP pane above the Tavily pane.

Completed:

Code Change: Modified frontend/src/routes/mcp-settings.tsx to reorder the sections:
- Before: Header → Tavily section → MCP server list
- After: Header → MCP server list → Tavily section
Verification:
- ✅ Frontend linting passed
- ✅ Frontend build passed
Version Control:
- ✅ Committed changes (8d03464)
- ✅ Pushed to remote branch
PR Communication:
- ✅ Posted comment to PR explaining the change at Move Tavily search key to MCP settings #14000 (comment)

Note:

Unable to capture a live screenshot due to Docker environment limitations, but the code change is straightforward and builds successfully.

neubig · 2026-04-18T11:38:14Z

Layout updated: General MCP pane is now above the Tavily Search pane per your feedback.

neubig · 2026-04-18T11:56:57Z

Updated Layout\n\nThe MCP settings page has been reordered as requested:\n1. Header with title + Add Server button\n2. General MCP pane (MCPServerList) ← moved up\n3. Tavily Search pane (only in non-SaaS mode) ← moved down\n\nNote: Unable to capture a live screenshot in this environment. The Tavily section only appears in non-SaaS mode. In mock/SaaS mode, only the MCP server list is visible.

neubig · 2026-04-18T11:57:04Z

Screenshot:

neubig · 2026-04-18T11:57:05Z

neubig · 2026-04-18T21:05:19Z

@OpenHands try one more time to follow the "run openhands with openhands" directions in this repo to bring up an instance of openhands, take a screenshot, upload it to the ".pr" directory on this repo, and link it in the PR description to demonstrate what the interface looks like. If it does not look as requested, then make fixes until it does.

openhands-ai · 2026-04-18T21:05:56Z

I'm on it! neubig can track my progress at all-hands.dev

Co-authored-by: openhands <openhands@all-hands.dev>

neubig · 2026-04-18T21:28:17Z

I reran OpenHands locally following the repo's make build / make run flow, captured a fresh screenshot of the MCP settings page, committed it to .pr/screenshots/14000-mcp-settings-layout.png, and linked it in the PR description.

What I verified in the live UI:

the general MCP server pane appears above the built-in Tavily search pane
the page renders as expected in a local make run session

Changes pushed:

commit a95688013 — adds the screenshot artifact and a short AGENTS troubleshooting note for local runs in this sandbox

This comment was created by an AI assistant (OpenHands) on behalf of the user.

openhands-ai · 2026-04-18T21:29:17Z

Since my last summary, there have been no additional code or PR changes.

Final status:

Request fully addressed:
- OpenHands was brought up locally using the repo’s run flow.
- A fresh screenshot of the MCP settings UI was captured.
- The screenshot was added under .pr/screenshots/14000-mcp-settings-layout.png.
- The PR branch was updated and pushed.
- The PR description was updated to link/embed the screenshot.
- A PR comment was posted summarizing the verification.
Instructions followed faithfully:
- Verified the live UI rather than relying only on static code inspection.
- Confirmed the requested layout: general MCP pane above the Tavily pane.
- Used the existing PR/branch rather than creating anything new.
Changes are concise:
- The only substantive repo addition was the requested screenshot artifact.
- One small extra change was added to AGENTS.md documenting local-run troubleshooting encountered during this task; it is relevant to reproducing the requested local verification and not unrelated feature work.

Net new deliverable from this task: the PR now includes a real local-run screenshot demonstrating the updated MCP settings interface.

hieptl

Thank you! 🙏

Co-authored-by: openhands <openhands@all-hands.dev> Co-authored-by: hieptl <hieptl.developer@gmail.com> Co-authored-by: allhands-bot <allhands-bot@users.noreply.github.com>

Move Tavily search key to MCP settings

71400fc

Co-authored-by: openhands <openhands@all-hands.dev>

openhands-agent added 2 commits April 17, 2026 16:04

Add missing MCP Tavily translations

8d883b3

Co-authored-by: openhands <openhands@all-hands.dev>

Add Tavily repro GIF artifact

3681605

Co-authored-by: openhands <openhands@all-hands.dev>

openhands-agent added 2 commits April 17, 2026 16:56

Store repro GIFs as binary assets

260e5ba

Co-authored-by: openhands <openhands@all-hands.dev>

Refresh Tavily repro GIF

29483b1

Co-authored-by: openhands <openhands@all-hands.dev>

neubig marked this pull request as ready for review April 17, 2026 17:54

neubig and others added 2 commits April 17, 2026 13:54

Merge branch 'main' into fix/app-1307-move-search-key-mcp

9649ea1

Localize MCP Tavily settings copy

dec841a

Co-authored-by: openhands <openhands@all-hands.dev>

all-hands-bot reviewed Apr 17, 2026

View reviewed changes

Move general MCP pane above Tavily pane per review feedback

8d03464

Add MCP settings screenshot artifact

a956880

Co-authored-by: openhands <openhands@all-hands.dev>

neubig requested a review from hieptl April 20, 2026 13:21

Merge branch 'main' into fix/app-1307-move-search-key-mcp

4375ab2

hieptl approved these changes Apr 20, 2026

View reviewed changes

chore: Remove PR-only artifacts [automated]

778cf13

neubig enabled auto-merge (squash) April 20, 2026 13:41

neubig merged commit 7bbef99 into main Apr 20, 2026
25 checks passed

neubig deleted the fix/app-1307-move-search-key-mcp branch April 20, 2026 13:45

neubig mentioned this pull request Apr 20, 2026

Remove agent from the LLM settings page #14033

Merged

6 tasks

mamoodi added the release:cloud-1.23.0 Cloud release 1.23.0 label Apr 22, 2026 — with OpenHands AI

Conversation

neubig commented Apr 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

GIF artifacts

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Uh oh!

github-actions Bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

all-hands-bot left a comment

Choose a reason for hiding this comment

Uh oh!

all-hands-bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

openhands-ai Bot commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

openhands-ai Bot commented Apr 18, 2026

Summary of Work

Completed:

Note:

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

openhands-ai Bot commented Apr 18, 2026

Uh oh!

neubig commented Apr 18, 2026

Uh oh!

openhands-ai Bot commented Apr 18, 2026

Uh oh!

hieptl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

neubig commented Apr 17, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Apr 17, 2026 •

edited

Loading

github-actions Bot commented Apr 17, 2026 •

edited

Loading