fix(settings): align MCP settings layout with other settings pages#13996
Merged
neubig merged 2 commits intoOpenHands:mainfrom Apr 18, 2026
Merged
Conversation
Removes max-w-[1000px], mx-auto, and px-6 from the MCP settings list view wrapper so that content starts from the left edge, consistent with secrets-settings and other settings pages. Fixes OpenHands#13982
neubig
requested changes
Apr 17, 2026
Contributor
neubig
left a comment
There was a problem hiding this comment.
Thanks @octo-patch please post a screenshot of the pages before and after the change so we can review the design.
Contributor
|
I have QAed this before and after, and it looks good. After: Before: |
neubig
approved these changes
Apr 18, 2026
Contributor
neubig
left a comment
There was a problem hiding this comment.
Thank you for the contribution @octo-patch ! For next contribution it'd be great if you could attach a screenshot to make it easier for us to QA.
devin-ai-integration Bot
pushed a commit
to OrpingtonClose/OpenHands
that referenced
this pull request
Apr 26, 2026
…penHands#13996) Co-authored-by: octo-patch <octo-patch@github.com> Co-authored-by: Graham Neubig <neubig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13982
Problem
The MCP settings page had
max-w-[1000px] mx-auto px-6on its outer container, which caused the content to be centered with extra padding rather than left-aligned. This made the MCP settings visually inconsistent with other settings pages (e.g., Secrets, Git settings) that start content from the left edge.Solution
Removed
max-w-[1000px],mx-auto, andpx-6from the list view wrapper inmcp-settings.tsx. The content now aligns to the left, consistent with the rest of the settings pages which use the same layout provided bySettingsLayout.Testing
secrets-settingsand other settings pages.