Bump condenser defaults: max_size 120->240 by xingyaoww · Pull Request #12267 · OpenHands/OpenHands

xingyaoww · 2026-01-05T17:31:37Z

Description

This PR updates the condenser defaults for existing users to address the staling issue in V1 conversations.

Changes

Database Migration (086):
- Updates existing users with condenser_max_size=120 to 240
- Adds new condenser_keep_first column to user_settings table
- Sets condenser_keep_first=4 for existing users who have condenser settings
Model Updates:
- Added condenser_keep_first field to Settings data model
- Added validator for condenser_keep_first (must be non-negative)
- Added condenser_keep_first column to enterprise UserSettings table
Code Updates:
- Updated _create_condenser method to accept and use condenser_keep_first parameter
- Updated _create_agent_with_context to pass condenser_keep_first from user settings
- Fixed outdated comment about SDK defaults (was incorrectly stating 120/4, now correctly states 240/2)

Background

The SDK has defaults of max_size=240 and keep_first=2, but existing users who had the old default of max_size=120 stored in the database were not benefiting from the increased default. This migration updates those users to the new values and adds support for customizing keep_first.

Testing

Migration tested locally
Pre-commit hooks pass

Related Issues

Addresses staling issues in V1 conversations by increasing the condenser history size.

@xingyaoww can click here to continue refining the PR

To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.openhands.dev/openhands/runtime:82e221e-nikolaik   --name openhands-app-82e221e   docker.openhands.dev/openhands/openhands:82e221e

github-actions · 2026-01-05T17:31:56Z

⚠️ This PR contains migrations. Please synchronize before merging to prevent conflicts.

malhotra5

LGTM

github-actions · 2026-01-06T20:20:23Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
openhands/app_server/app_conversation
app_conversation_service_base.py
openhands/server/session
session.py
Project Total

_{This report was generated by python-coverage-comment-action}

openhands-ai · 2026-01-06T20:20:40Z

Looks like there are a few issues preventing this PR from being merged!

GitHub Actions are failing:
- Docker

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #12267 at branch `bump-condenser-defaults`

Feel free to include any additional details that might help me get this PR into a better state.

_{^{You can manage your notification settings}}

all-hands-bot · 2026-01-06T20:21:44Z

Feature deployment is available at: https://ohpr-12267.staging.all-hands.dev
Redirect URI for GitHub App is https://ohpr-12267.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint
Last updated: Jan 06, 2026, 03:21:43 PM ET

xingyaoww · 2026-01-06T20:31:01Z

@OpenHands please check datadog API for logs - looks like the DB migration didn't work for https://ohpr-12267.staging.all-hands.dev/

I still see 120 max history size in the UI, any idea?

openhands-ai · 2026-01-06T20:31:12Z

I'm on it! xingyaoww can track my progress at all-hands.dev

openhands-ai · 2026-01-06T20:41:03Z

Summary

I investigated the issue using the Datadog API and found the root cause of why you're still seeing 120 in the UI despite the migration running.

Root Cause Analysis

From the Datadog logs, I confirmed that:

The migration DID run at 2026-01-06T20:21:08.235Z on the staging deployment (Running upgrade 085 -> 086, bump condenser defaults: max_size 120->240)
The migration only updated rows where condenser_max_size == 120, but most users have NULL in the database
The application code defaults NULL to 120 in both frontend (DEFAULT_SETTINGS.condenser_max_size: 120) and backend (settings.condenser_max_size or 120)

So users with NULL in the database were not updated by the migration, and the UI showed 120 because that's the fallback default.

Fix Applied

I pushed a commit that:

Updated the migration to also update NULL values to 240:

# Update users with NULL value (which defaulted to 120 in application code)
op.execute(
    user_settings_table.update()
    .where(user_settings_table.c.condenser_max_size.is_(None))
    .values(condenser_max_size=240)
)

Updated frontend default from 120 to 240 in frontend/src/services/settings.ts
Updated backend default from 120 to 240 in openhands/server/session/session.py (V0 code)
Updated test comments to reflect correct SDK defaults (240/2 instead of 120/4)

Next Steps

Once the staging deployment redeploys with this fix, the migration will:

Update all users with condenser_max_size = 120 to 240
Update all users with condenser_max_size = NULL to 240

And new users will get 240 as the default instead of 120.

The changes have been pushed to the bump-condenser-defaults branch.

View full conversation

all-hands-bot · 2026-01-06T20:55:23Z

Feature deployment is available at: https://ohpr-12267.staging.all-hands.dev
Redirect URI for GitHub App is https://ohpr-12267.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint
Last updated: Jan 06, 2026, 03:55:22 PM ET

xingyaoww · 2026-01-06T20:57:20Z

@OpenHands please fix these - we should set default value to 240 in FE and backend as well including the test

The application code defaults NULL to 120 in both frontend (DEFAULT_SETTINGS.condenser_max_size: 120) and backend (settings.condenser_max_size or 120)

openhands-ai · 2026-01-06T20:57:29Z

I'm on it! xingyaoww can track my progress at all-hands.dev

- Add migration 086 to update existing users with condenser_max_size=120 to 240 - Add new condenser_keep_first column to user_settings table - Set condenser_keep_first=4 for existing users who have condenser settings - Update Settings model with condenser_keep_first field and validator - Update _create_condenser to accept and use condenser_keep_first parameter - Fix outdated comment about SDK defaults (was 120/4, now 240/2) Co-authored-by: openhands <openhands@all-hands.dev>

…or keep_first Remove condenser_keep_first column and related code since the SDK default will be used automatically when the column is not present. Co-authored-by: openhands <openhands@all-hands.dev>

The migration was only updating rows where condenser_max_size=120, but most users have NULL in the database (which defaulted to 120 in application code). Changes: - Migration now updates both condenser_max_size=120 AND NULL values to 240 - Updated frontend default from 120 to 240 - Updated backend default from 120 to 240 (V0 session.py) - Updated test comments to reflect correct SDK defaults (240/2) Co-authored-by: openhands <openhands@all-hands.dev>

openhands-ai · 2026-01-06T20:59:59Z

I've fixed the failing GitHub Action by rebasing the bump-condenser-defaults branch on top of the latest main branch.

Issue: The check-sync action was failing because the base branch (main) was not an ancestor of the PR branch. This happens when new commits are pushed to main after the PR branch was created.

Fix: Rebased the PR branch on top of origin/main:

The branch now includes the latest commit from main: 1907ebeaa feat: add chat message skeletons and improve routing stability (#12223)
Force-pushed the rebased branch to update the PR

The PR should now pass the check-sync action. You can monitor the new workflow run at: #12267

View full conversation

all-hands-bot · 2026-01-06T21:13:58Z

Feature deployment is available at: https://ohpr-12267.staging.all-hands.dev
Redirect URI for GitHub App is https://ohpr-12267.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint
Last updated: Jan 06, 2026, 04:13:57 PM ET

xingyaoww · 2026-01-06T21:19:07Z

@OpenHands check datadog, i got these error when i open the deployment:

400 Bad Request
Request Header Or Cookie Too Large
nginx/1.29.4

openhands-ai · 2026-01-06T21:19:18Z

I'm on it! xingyaoww can track my progress at all-hands.dev

all-hands-bot · 2026-01-06T21:20:25Z

Feature deployment is available at: https://ohpr-12267.staging.all-hands.dev
Redirect URI for GitHub App is https://ohpr-12267.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint
Last updated: Jan 06, 2026, 04:20:25 PM ET

openhands-ai · 2026-01-06T21:21:57Z

Summary

I investigated the "400 Bad Request - Request Header Or Cookie Too Large" error you're experiencing when opening the deployment at https://ohpr-12267.staging.all-hands.dev using the Datadog API.

Findings

The error is NOT appearing in Datadog logs - This is expected because the 400 error happens at the nginx/ingress level before the request reaches the application, so it doesn't get logged to the application logs.

Related Keycloak errors found - I did find authentication errors in the logs:

Redirection URL does not contain a state parameter. providerId=github, 
redirectionUrl=https://ohpr-12267.auth.staging.all-hands.dev/realms/allhands/broker/github/endpoint

This suggests the OAuth state parameter is being lost, likely due to the cookie size issue.

Root Cause

The "Request Header Or Cookie Too Large" error is a client-side browser issue, not a code problem. It happens when:

Too many cookies have accumulated for the *.staging.all-hands.dev domain
Each PR deployment (ohpr-XXXXX) creates its own set of authentication cookies
Over time, testing multiple PR deployments causes cookie accumulation that exceeds nginx's header size limit

Solution

To fix this immediately:

Clear cookies for *.staging.all-hands.dev and *.all-hands.dev domains in your browser
Or try accessing the deployment in an incognito/private browser window

This is not a bug in the PR code - it's a common issue when testing multiple staging deployments that share a parent domain. No code changes are needed.

View full conversation

xingyaoww · 2026-01-06T21:27:18Z

OK! Confirmed this is fixed.

#12267 (comment) -> this issue is just a blip

malhotra5

LGTM!

xingyaoww commented Jan 6, 2026

View reviewed changes

Comment thread enterprise/migrations/versions/086_bump_condenser_defaults.py Outdated

xingyaoww marked this pull request as ready for review January 6, 2026 20:09

xingyaoww requested review from chuckbutkus, hieptl, malhotra5 and tofarr as code owners January 6, 2026 20:09

xingyaoww changed the title ~~Bump condenser defaults: max_size 120->240, add keep_first=4~~ Bump condenser defaults: max_size 120->240 Jan 6, 2026

malhotra5 approved these changes Jan 6, 2026

View reviewed changes

xingyaoww added the deploy label Jan 6, 2026

xingyaoww requested a review from amanape as a code owner January 6, 2026 20:39

openhands-agent added 3 commits January 6, 2026 20:59

Simplify PR: only bump condenser_max_size 120->240, use SDK default f…

b3864d4

…or keep_first Remove condenser_keep_first column and related code since the SDK default will be used automatically when the column is not present. Co-authored-by: openhands <openhands@all-hands.dev>

xingyaoww force-pushed the bump-condenser-defaults branch from 89ead3f to 82e221e Compare January 6, 2026 20:59

xingyaoww added deploy and removed deploy labels Jan 6, 2026

xingyaoww requested a review from malhotra5 January 6, 2026 21:18

malhotra5 approved these changes Jan 6, 2026

View reviewed changes

xingyaoww merged commit af5c227 into main Jan 6, 2026
30 checks passed

xingyaoww deleted the bump-condenser-defaults branch January 6, 2026 21:43

Conversation

xingyaoww commented Jan 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Background

Testing

Related Issues

Uh oh!

github-actions Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

malhotra5 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Uh oh!

all-hands-bot commented Jan 6, 2026

Uh oh!

xingyaoww commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Summary

Root Cause Analysis

Fix Applied

Next Steps

Uh oh!

all-hands-bot commented Jan 6, 2026

Uh oh!

xingyaoww commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Uh oh!

all-hands-bot commented Jan 6, 2026

Uh oh!

xingyaoww commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Uh oh!

all-hands-bot commented Jan 6, 2026

Uh oh!

openhands-ai Bot commented Jan 6, 2026

Summary

Findings

Root Cause

Solution

Uh oh!

xingyaoww commented Jan 6, 2026

Uh oh!

malhotra5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xingyaoww commented Jan 5, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jan 5, 2026 •

edited

Loading

github-actions Bot commented Jan 6, 2026 •

edited

Loading