refactor(frontend): Refactor tests to use Zustand's native state setting instead of vi.mock for stores#11980
Merged
amanape merged 5 commits intoOpenHands:mainfrom Dec 11, 2025
Conversation
- Replace vi.mock with store.setState() in browser.test.tsx - Replace vi.mock with store.setState() in interactive-chat-box.test.tsx - Replace vi.mock with store.setState() in chat-interface.test.tsx - Replace vi.mock with store.setState() in actions.test.tsx - Use real store instances instead of mock objects
amanape
approved these changes
Dec 11, 2025
Contributor
amanape
left a comment
There was a problem hiding this comment.
Thank you for this pull request and for promoting good practices in our codebase!
I also took the opportunity to remove two outdated slice mocks from stores that have since been eliminated.
abhayymishraa
pushed a commit
to abhayymishraa/OpenHands
that referenced
this pull request
Dec 14, 2025
…ing instead of vi.mock for stores (OpenHands#11980) Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>
afanty2021
pushed a commit
to afanty2021/OpenHands
that referenced
this pull request
Dec 17, 2025
…ing instead of vi.mock for stores (OpenHands#11980) Co-authored-by: amanape <83104063+amanape@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR
Removed unnecessary vi.mock usage in Zustand store tests and switched to using store.setState() directly, since the project already includes an auto-reset mock in mocks/zustand.ts.
Files changed:
browser.test.tsx- removed vi.mock for browser-storeinteractive-chat-box.test.tsx- removed vi.mock for conversation-storechat-interface.test.tsx- removed vi.mock for error-message-store and optimistic-user-message-storeactions.test.tsx- removed vi.mock for command-storeChange Type
Checklist
Fixes
Resolves #11951
Release Notes