Refactor return statement to simplify get_supported_llm_models method#11947
Merged
enyst merged 1 commit intoOpenHands:mainfrom Dec 9, 2025
Merged
Refactor return statement to simplify get_supported_llm_models method#11947enyst merged 1 commit intoOpenHands:mainfrom
enyst merged 1 commit intoOpenHands:mainfrom
Conversation
The method sorted returns already a list, i.e., list(sorted(set(model_list))) is just sorted(set(model_list))
afanty2021
pushed a commit
to afanty2021/OpenHands
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of PR
I was looking inside the code and I saw this small nit, and I decided to open a PR. My small contribution to this fantastic project ;-) .
Here, you are doing
list(sorted(set(model_list)))butsortedreturns already a list ref. Therefore, this is equivalent to havesorted(set(model_list)), and you spare a method call.Change Type
Checklist
Fixes
Resolves #(issue)
Release Notes