SeaState: Allow WaveStMod=1 with WaveMod=0 #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For reference, this PR addresses this issue: #2744 |
andrew-platt
approved these changes
Jul 8, 2025
Collaborator
jjonkman
approved these changes
Jul 9, 2025
RBergua
approved these changes
Jul 9, 2025
Collaborator
|
Backport to 4.1.2 |
andrew-platt
added a commit
that referenced
this pull request
Jul 25, 2025
Backport of #2906 ( SeaState: Allow WaveStMod=1 with WaveMod=0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR enables
WaveStMod=1(vertical wave stretching) whenWaveMod=0(calm water).Previously, SeaState automatically sets
WaveStMod=0(no wave stretching) ifWaveMod=0. HydroDyn only considers the vertical displacements of strip-theory member nodes whenWaveStMod/=0. This prevents accurate linearization if the structure has a large heave offset because linearization requiresWaveMod=0, which, in turn, forcesWaveStMod=0.This PR allows the user to set
WaveStMod=1when performing linearization, so that the vertical offset of the strip-theory members and the resulting change in wetted lengths are taken into account.Impacted areas of the software
SeaState
Test results, if applicable
No change to existing test results.