[OLAF] Bug Fix: Twist Not Computed in OLAF cases when Polar Projection is used, resulting in wrong Fn, Ft outputs #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4430e82 to
f08c4e8
Compare
andrew-platt
approved these changes
Aug 8, 2024
ebranlard
added a commit
to ebranlard/openfast
that referenced
this pull request
Sep 16, 2024
ebranlard
added a commit
to ebranlard/openfast
that referenced
this pull request
Sep 17, 2024
This was referenced Dec 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
Fixes #2348, see bug description.
Impacted areas of the software
AeroDyn, OLAF
Additional supporting information
I've tried to cleanup the code a bit as well, but restrained myself from doing too much. I've renamed "curve" to "cant", and introduce a misc variable "toe" as well for output. The "Curve" output should probably be renamed. The different projection methods return twist, toe and cant. We could make those optional in some case, but I don't know how much time we would save by doing that.
Some further cleaning up can be done to avoid redundancies between OLAF and BEM when computing geometrical parameters (e.g. local polar grid "l" orientation, rotor radius in the normal plane, toe, cant, twist). The different projection methods have introduced some complexities and corner cases unfortunately. One road block I see is that for a vertical axis turbines, the local polar grid, toe, cant and twist, might not be needed or defined differently.
Test results, if applicable
Should be unchanged.