Fix funding modifier and reset timing#1586
Merged
FilmBoy84 merged 1 commit intoOpenApoc:masterfrom Mar 6, 2026
Merged
Conversation
Collaborator
|
Very nice spot and thankyou for the fix 🍻 Tested both with and without debug to end of week; appears to work as intended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1585
The weekly player update was clearing the weekly score before the funding screen could read it. This resets the score only after it is used in the funding screen.
The funding modifier calculation was breaking early, causing the player to recieve the max score modifier if the score was positive. That explains the constant 25% increase every week.