[Ruby] [Faraday] Adds 'params_encoder' config option for clients#9839
[Ruby] [Faraday] Adds 'params_encoder' config option for clients#9839wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
I opened a PR upstream with the same changes: OpenAPITools/openapi-generator#9839 fixes: #8941 https://pulp.plan.io/issues/8941
There was a problem hiding this comment.
minor suggestion: what about declaring the hash inline without declaring a variable request_options to store it?
There was a problem hiding this comment.
Either way works for me. I'll update to be inline.
I can't find instructions for how to regenerate the samples. Can you please remind me?
There was a problem hiding this comment.
Nevemind ... I found the command in the failed CI run.
There was a problem hiding this comment.
I saw you pushed some changes but don't any changes to this file. Did you commit the change before the push?
There was a problem hiding this comment.
I decided not to make the change because the line was very long.
I ran the script to update the samples, but it seems like there are more changes that it didn't pick up. Do you know what I am doing wrong?
There was a problem hiding this comment.
That's ok. Let's see if someone from the community can help make that enhancement later.
I've updated the samples via 46cd6b8
95125ac to
7cd00a9
Compare
|
CI reported the following errors: Can you please take a look when you've time? Ref: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/232392701 |
I'll take a look |
|
Travis CI tests failed: Please take a look when you've time: https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/248929415 To run the test locally please refer to https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests#how-to-add-integration-tests-for-new-petstore-samples. |
The partial templates were renamed because they no longer hold tls settings exclusively. fixes: OpenAPITools#9838
|
Travis tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/249169990 |
…penAPITools#9839) The partial templates were renamed because they no longer hold tls settings exclusively. fixes: OpenAPITools#9838
The partial templates were renamed because they no longer hold tls
settings exclusively.
fixes: #9838